Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Yarn to v3 (berry) #8461

Closed
wants to merge 16 commits into from
Closed

update Yarn to v3 (berry) #8461

wants to merge 16 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 18, 2023 •
edited
Loading

closes: #451

Description

Version 4 seems close to release (4.0.rc53 is out) but the breaking changes won't affect us much so let's go ahead to v3 now. https://github.com/yarnpkg/berry/blob/master/CHANGELOG.md#master

Security Considerations

n/a. Though does open the option to keep the registry cache in the repo, reducing supply chain risk.

Scaling Considerations

n/a

Documentation Considerations

I haven't noticed anything breaking workflows. If they are it deserves a loud Slack announcement.

Testing Considerations

CI

Upgrade Considerations

n/a

@turadg
Copy link
Member Author

turadg commented Oct 18, 2023

Need to fix CI: yarnpkg/berry#2621

@turadg turadg marked this pull request as draft October 18, 2023 20:53
@turadg turadg force-pushed the 451-yarn-3 branch 3 times, most recently from 835ed0c to 8b61a2f Compare December 14, 2023 00:02
@turadg turadg force-pushed the 451-yarn-3 branch 2 times, most recently from 5af1c3a to cec543f Compare December 22, 2023 14:48
@turadg
Copy link
Member Author

turadg commented Dec 22, 2023 •
edited
Loading

dapp tests failing to run agoric bin:

❯ ./bin/agoric --version
(ReferenceError#1)
ReferenceError#1: require is not defined in ES module scope, you can use import instead
This file is being treated as an ES module because it has a '.js' file extension and '/opt/agoric/yarn3-sdk/packages/agoric-cli/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
This file is being treated as an ES module because it has a '.js' file extension and '/opt/agoric/yarn3-sdk/packages/agoric-cli/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension.
  at Object.eval (eval at <anonymous> (eval at makeEvaluate (file:///opt/agoric/yarn3-sdk/node_modules/ses/src/make-evaluate.js:92:27)), <anonymous>:1)
  at eval (eval at makeEvaluate (file:///opt/agoric/yarn3-sdk/node_modules/ses/src/make-evaluate.js:92:27), <anonymous>:12:22)
  at safeEvaluate (file:///opt/agoric/yarn3-sdk/node_modules/ses/src/make-safe-evaluator.js:78:14)
  at eval (file:///opt/agoric/yarn3-sdk/node_modules/ses/src/make-eval-function.js:22:14)
  at Object.<anonymous> (/opt/agoric/yarn3-sdk/node_modules/@yarnpkg/core/lib/miscUtils.js:262:21)

Something in the bowels of SES. Any ideas @kriskowal ?

UPDATE: it was the eval('require') that the package does to work around something in Webpack. I don't know why you'd build Yarn with Webpack but this patch works for now https://github.com/Agoric/agoric-sdk/pull/8461/files#diff-d6b4713855f18df4a84e2fb446d5915b8d5fcafe0be935795c31ddc653e9f4c9

@turadg turadg mentioned this pull request Dec 22, 2023
Open
@mhofman
Copy link
Member

mhofman commented Dec 27, 2023

n/a. Though does open the option to keep the registry cache in the repo, reducing supply chain risk.

Can you clarify?

Version 4 seems close to release (4.0.rc53 is out) but the breaking changes won't affect us much so let's go ahead to v3 now.

If we're going through the trouble of upgrading with a breaking change version, have we considered alternative package managers (npm or pnpm)?

In general I am concerned about these low level changes that affect the structure of the repo while we have a release branch to maintain. The rebuild of xsnap motivation seems like an issue that should be fixed by our xsnap package, not the package manager used.

turadg added 16 commits December 27, 2023 12:24
@turadg
chore(deps): update Yarn 1 to 3 (berry)
c922dd8
@turadg
build: configure yarn cache and linker
262fbae
@turadg
build: yarn install to rebuild yarn.lock
28e574f
@turadg
chore(deps): adopt workspace:* protocol
1836589 
find-replace:
("@agoric/.*":) .*"
$1 "workspace:*"
@turadg
chore: Yarn berry compatibility
dec9065
@turadg
lint: berry-compatible lint glob
fb57739 
work around mysticatea/npm-run-all#200
@turadg
chore: migrate protobufjs patch to yarn
c1642e9 
version 7.0+ used in cosmic-swingset already has the fix
@turadg
chore(deps): ava devDependency
bcbb155
@turadg
chore(deps): ava-xs devDependency
f4bf24a
@turadg
chore: yarn run --top-level for Berry compat
af71b63 
yarnpkg/berry#2825
@turadg
chore: remove dead check-mismatched-dependencies
39062c9
@turadg
chore: compat with Berry workspace list results
7a29354
@turadg
refactor: use Yarn API directly
aa56469
@turadg
chore(deps): declare CLI dep
09e0424
@turadg
refactor: no JS dependence on yarn
65591e7
@turadg
chore(deps): declare node-gyp dep
728f98d
@turadg
Copy link
Member Author

turadg commented Jan 8, 2024

Blocked by #8381

@turadg turadg mentioned this pull request Jan 8, 2024
Merged
@turadg turadg mentioned this pull request Jun 20, 2024
Merged
1 task
mergify bot added a commit that referenced this pull request Jun 21, 2024
@mergify
yarn by corepack (#9542)
52e0339 
refs: #8461 

## Description
Rely on corepack for yarn version.

Bump the yarn version to latest.

### Security Considerations
none
### Scaling Considerations
none

### Documentation Considerations

I think our docs already say to start with `corepack enable`. Not certain.

### Testing Considerations
- [x] run locally

Fails if corepack not yet enabled. It should be, so if this change causes errors that would help us to detect. Corepack is important in order to upgrade to Yarn 4 eventually.

### Upgrade Considerations
none
@turadg turadg mentioned this pull request Aug 22, 2024
Draft
@turadg turadg closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eventually move to Yarn 2+ (currently 4)
2 participants
@turadg @mhofman